Test Details Overview

Replace start_stop_guard with the START macro (#5288)

* Replace start_stop_guard with the START macro

START (component) starts a component and stops it when the enclosing
scope ends, also when an ASSERT_* returns early. Like gtest's
SCOPED_TRACE, it declares a guard object the test never names.
Besides a component it takes a raw pointer, std::shared_ptr or
std::unique_ptr to one. A test can still stop the component earlier
by calling stop () on it directly.

The guard behind the macro lives in its own header, included from
testutil.hpp.

* Use START in the message processor tests

A failed ASSERT_* returned before processor.stop () and left the
shard threads running into the destructor, whose debug_assert then
aborted the whole test binary. The explicit stop stays, so the checks
after it still read a stopped processor.

* Remove the unused stop_guard test helper

Nothing uses it anymore; START covers starting and stopping a
component within a test.

__________

Type: commit

Hash: e6fb3cd2963d718efa119a665dbbde22e79bf6ba

Created: yesterday

__________

gr0v1ty/nano-node:e6fb3cd2963d718efa119a665dbbde22e79bf6ba

Test Results

Test Case Status Duration Median Deviation Log Graph
5n4pr_conf_10k_bintree PASS 108 s -1.0 s GitHub job logs Show
5n4pr_conf_10k_change PASS 132 s 2.0 s GitHub job logs Show
5n4pr_conf_change_dependant PASS 127 s 12.0 s GitHub job logs -
5n4pr_conf_change_independant PASS 140 s 28.0 s GitHub job logs -
5n4pr_conf_send_dependant PASS 114 s 0.0 s GitHub job logs -
5n4pr_conf_send_independant PASS 125 s 11.0 s GitHub job logs -
5n4pr_rocks_10k_bintree PASS 116 s 4.0 s GitHub job logs -
5n4pr_rocks_10k_change PASS 139 s -17.0 s GitHub job logs -