Fix out-of-range channel access in peer_history_restart (#5160) The restarted node reopens the same data directory and therefore loads the same node id. node1 still holds the stopped node's channel until its next cleanup tick and rejects the reconnect as a duplicate, closing the socket, so the test was asserting against a channel that was already dead and had merely not been purged yet. When that purge landed between the `empty ()` check and the `list (2)` call, the returned deque was empty and `list[0]` ran off the end, aborting on the MSVC debug bounds check. Wait for the stale channel to be dropped before restarting, so the reconnect is accepted and the test verifies a live connection, and replace the `empty ()` plus `list[0]` pair with a single `find_channel` predicate that cannot observe a torn state.
__________
Type: commit
Hash: ba76a02e2350be4755f4ab784608e6f078fa6ecc
Created: yesterday
__________
gr0v1ty/nano-node:ba76a02e2350be4755f4ab784608e6f078fa6ecc
| Test Case | Status | Duration | Median Deviation | Log | Graph |
|---|---|---|---|---|---|
| 5n4pr_conf_10k_bintree | PASS | 113 s | -2.5 s | - | Show |
| 5n4pr_conf_10k_change | PASS | 166 s | 14.0 s | - | Show |
| 5n4pr_conf_change_dependant | PASS | 114 s | 1.0 s | - | - |
| 5n4pr_conf_change_independant | FAIL | 3 s | -114.0 s | Show | - |
| 5n4pr_conf_send_dependant | PASS | 111 s | -4.0 s | - | - |
| 5n4pr_conf_send_independant | PASS | 108 s | -6.0 s | - | - |
| 5n4pr_rocks_10k_bintree | PASS | 122 s | 0.0 s | - | - |
| 5n4pr_rocks_10k_change | PASS | 202 s | 29.0 s | - | - |