Report preconfigured peer connect failures (#5092)
* Report preconfigured peer connect failures
Propagate outbound TCP connection outcomes through reachout callbacks, including local rejection errors.
Log failed attempts to explicitly configured peers and cover callback success and failure paths in tcp listener tests.
* Replace the nullable `connect_callback` default (`{}`) with no-op lambda default
Allowing call sites to invoke the callback
unconditionally and removing all `if (callback)` guards.
* Add `nano::noop<F>()` helper; replace inline no-op lambdas
Replace repeated inline no-op lambda defaults with a reusable
`nano::noop<F>()` utility that constructs a type-erased no-op
callable for any `std::function<void(Args...)>` specialization.
__________
Type: commit
Hash: 8f73988fa8d5554bcfa8a91581cb3be04c2091fb
Created: yesterday
__________
gr0v1ty/nano-node:8f73988fa8d5554bcfa8a91581cb3be04c2091fb
| Test Case | Status | Duration | Median Deviation | Log | Graph |
|---|---|---|---|---|---|
| 5n4pr_conf_10k_bintree | PASS | 112 s | 2.0 s | - | Show |
| 5n4pr_conf_10k_change | PASS | 177 s | -19.0 s | - | Show |
| 5n4pr_conf_change_dependant | PASS | 118 s | 7.0 s | - | - |
| 5n4pr_conf_change_independant | FAIL | 3 s | -106.0 s | Show | - |
| 5n4pr_conf_send_dependant | PASS | 108 s | -3.0 s | - | - |
| 5n4pr_conf_send_independant | PASS | 110 s | -1.0 s | - | - |
| 5n4pr_rocks_10k_bintree | PASS | 111 s | -3.0 s | - | - |
| 5n4pr_rocks_10k_change | PASS | 235 s | 55.0 s | - | - |