Test Details Overview

Stabilise flaky active_elections.fork_replacement_tally (#5091)

The test gated on election->votes ().size () == max_blocks before counting
representative votes, and timed out (seen on macOS/Windows) once that size
exceeded max_blocks. votes () returns last_votes, keyed by account, not by
retained block: replace_by_weight evicts a fork via remove_block and erases
the votes present at that moment, but a fork's cached vote can be applied
after the fork has already been evicted, leaving an orphan vote that is never
cleaned. On slow runners these orphans accumulate, so votes ().size () settles
above max_blocks permanently and the equality never holds.

Count only representatives whose vote still points at a block retained in the
election, which is the stable quantity the test means to assert (the highest
-weight forks that survived replacement), and drop the votes ().size () gate;
election->blocks ().size () == max_blocks is already asserted separately.

Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

__________

Type: commit

Hash: 6acad638498d3f152ef6164f72bee7182aa32e35

Created: today

__________

gr0v1ty/nano-node:6acad638498d3f152ef6164f72bee7182aa32e35