Test Details Overview

Fix race in send_node_id_handshake_tcp (#5191)

The test asserted that neither node had a channel immediately after
start_tcp, which only posts a connect coroutine onto the listener strand
and returns: the connect, the handshake and the channel registration all
run on io threads, so the channel can be there before the assertion runs.
CI hit this on macOS.

Assert the baseline before the connection is started, as multi_keepalive
does. Also drop an unused weak_ptr left over from an earlier signature.

Co-authored-by: Claude Opus 5 <noreply@anthropic.com>

__________

Type: commit

Hash: 53ed21d049c4f571f1495a7b55033370175d853d

Created: yesterday

__________

gr0v1ty/nano-node:53ed21d049c4f571f1495a7b55033370175d853d

Test Results

Test Case Status Duration Median Deviation Log Graph