Test Details Overview

Decouple confirmation_solicitor from election internals

The solicitor reached into election private state (last_votes, is_quorum,
status.winner) through friendship, which forced its tests to construct
real elections and poke their internals via friend declarations.

It now consumes an election_snapshot, a plain view built by the election
under its own lock, carrying the root, winner, quorum flag and the vote
map. The friend declarations are gone and the solicitor tests exercise
the rep filtering and batching with hand-built snapshots.

Also flip add and broadcast to return true on success instead of the
inverted error convention.

__________

Type: commit

Hash: 0ee0b34ecc7f45807a96014fd1ee86ae99347e5b

Created: yesterday

__________

gr0v1ty/nano-node:0ee0b34ecc7f45807a96014fd1ee86ae99347e5b