Serialize wallet password clearing against rekey wallet::lock cleared the password fan without holding the store mutex, so a clear landing in the middle of a rekey was overwritten by it and the wallet remained unlocked even though lock() had completed. The clear now happens in wallet_store under the same mutex as rekey and attempt_password: either it lands after the rekey and the wallet ends up locked, or before it, in which case the rekey fails cleanly.
__________
Type: commit
Hash: 0edd243d89ed8e9771dc4138eab06525c4aa09bd
Created: yesterday
__________
gr0v1ty/nano-node:0edd243d89ed8e9771dc4138eab06525c4aa09bd
| Test Case | Status | Duration | Median Deviation | Log | Graph |
|---|---|---|---|---|---|
| 5n4pr_conf_10k_bintree | PASS | 125 s | 11.0 s | - | Show |
| 5n4pr_conf_10k_change | PASS | 170 s | 12.0 s | - | Show |
| 5n4pr_conf_change_dependant | PASS | 109 s | -5.0 s | - | - |
| 5n4pr_conf_change_independant | FAIL | 582 s | 466.0 s | Show | - |
| 5n4pr_conf_send_dependant | PASS | 109 s | -7.0 s | - | - |
| 5n4pr_conf_send_independant | PASS | 110 s | -4.0 s | - | - |
| 5n4pr_rocks_10k_bintree | PASS | 119 s | -5.0 s | - | - |
| 5n4pr_rocks_10k_change | PASS | 169 s | 3.0 s | - | - |